Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): ensure payload url has no protocol #8675

Merged
merged 3 commits into from
Nov 3, 2022
Merged

fix(nuxt): ensure payload url has no protocol #8675

merged 3 commits into from
Nov 3, 2022

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 3, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Use URL parser to extract pathname from URL for internal _getPayloadURL utility and ensure input does not contain hostname or search params.

Previously an invalid URL like loadPayload('/\\example.com') could be passed.

Credits to @OhB00 for discovering this.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Nov 3, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Nov 3, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 4fd9a8c
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63643eeffea91b0008e8a485

@pi0 pi0 merged commit 19a2cd1 into main Nov 3, 2022
@pi0 pi0 deleted the fix/payload-proto branch November 3, 2022 22:28
@pi0 pi0 mentioned this pull request Nov 3, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants