Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

docs: disable transitions by default #8434

Merged
merged 1 commit into from
Oct 24, 2022
Merged

docs: disable transitions by default #8434

merged 1 commit into from
Oct 24, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Oct 24, 2022

πŸ”— Linked issue

hotfix to work around nuxt/nuxt#15239

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I do not believe we are currently using transitions so we probably should disable these anyway. This also serves to seriously reduce a memory leak that we're looking into.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 October 24, 2022 08:30
@danielroe danielroe self-assigned this Oct 24, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 24, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe added the documentation Improvements or additions to documentation label Oct 24, 2022
@netlify
Copy link

netlify bot commented Oct 24, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 5cb6985
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63564d1efa3dc600085ee9ac
😎 Deploy Preview https://deploy-preview-8434--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. /cc @atinux

@pi0 pi0 merged commit 6de1431 into main Oct 24, 2022
@pi0 pi0 deleted the docs/disable-transitions branch October 24, 2022 08:34
@atinux
Copy link
Member

atinux commented Oct 24, 2022

Thanks @danielroe

Shall we simply disable transitions by default in Nuxt 3? πŸ€”

@danielroe
Copy link
Member Author

There is merit in that. They cause issues like nuxt/nuxt#13471 when many users may not be using them at all ...

wdyt @pi0?

Copy link
Member

atinux commented Oct 24, 2022

It also brings Nuxt 3 as light as possible when starting

@pi0
Copy link
Member

pi0 commented Oct 24, 2022

Makese sense to disable transitions by default. We only need proper way to guide users to enable it back

@manniL
Copy link
Member

manniL commented Oct 24, 2022

I think disabling them by default is a good idea to reduce friction, as long as docs cover how to use them (e.g. with an extra section).

@pi0 pi0 mentioned this pull request Nov 3, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants