Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(pages): ignore expression delimiters within quotes #6033

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14312

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR fixes an oversight in the original code, which followed nesting within quotes.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working pages ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Jul 21, 2022
@danielroe danielroe requested a review from pi0 July 21, 2022 12:25
@danielroe danielroe self-assigned this Jul 21, 2022
@netlify
Copy link

netlify bot commented Jul 21, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit e6ece4e
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62d958b7debcb2000851495e

@pi0 pi0 merged commit 8f7b9f9 into main Jul 21, 2022
@pi0 pi0 deleted the fix/nested-quotes branch July 21, 2022 13:49
@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefinePageMeta formatting error when converting to const meta
2 participants