Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use explicit imports of types #715

Merged
merged 3 commits into from
Sep 10, 2024
Merged

fix: use explicit imports of types #715

merged 3 commits into from
Sep 10, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

noticed empty declarations: https://unpkg.com/browse/@nuxt/[email protected]/dist/runtime/client.d.ts

build-time warning was:

src/runtime/client.ts(3,14): error TS2742: The inferred type of 'devToolsClient' cannot be named without a reference to '../../node_modules/@nuxt/devtools-kit/dist/types'. This is likely not portable. A type annotation is necessary.

After this change we do have declarations again but the NuxtDevtoolsIframeClient is resolved as any.

@danielroe danielroe added the bug Something isn't working label Aug 26, 2024
@danielroe danielroe requested a review from antfu August 26, 2024 20:25
@danielroe danielroe self-assigned this Aug 26, 2024
@antfu
Copy link
Member

antfu commented Sep 10, 2024

I think it's still better to have it and investigate later, as assigning any would still be better than empty file

Copy link

cloudflare-workers-and-pages bot commented Sep 10, 2024

Deploying nuxt-devtools with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: fd6d4c3
Status:Β βœ…Β  Deploy successful!
Preview URL: https://f5953592.nuxt-devtools.pages.dev
Branch Preview URL: https://fix-explicit-type-imports.nuxt-devtools.pages.dev

View logs

@antfu antfu marked this pull request as ready for review September 10, 2024 10:28
@antfu antfu merged commit 4c54247 into main Sep 10, 2024
3 checks passed
@antfu antfu deleted the fix/explicit-type-imports branch September 10, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants