Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply runtimeConfig proxy directly to ctx.config #552

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #458

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds a plugin to normalize $config with a Proxy, moving it from the composable useRuntimeConfig into the app itself, which means that usage from ctx.$config within plugins works as expected for user plugins.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Sep 23, 2022
@danielroe danielroe self-assigned this Sep 23, 2022
@danielroe danielroe merged commit 29e3cbc into main Sep 23, 2022
@danielroe danielroe deleted the fix/config-proxy branch September 23, 2022 21:02
@danielroe danielroe mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$config doesn't work on client
1 participant