Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test for using decorators in stories #823

Merged
merged 4 commits into from
Dec 27, 2024

Conversation

tobiasdiez
Copy link
Collaborator

@tobiasdiez tobiasdiez commented Dec 11, 2024

🔗 Linked issue

Verifying that #808 is indeed fixed.

📚 Description

Copy link

netlify bot commented Dec 11, 2024

👷 Deploy request for nuxt-storybook pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8fce808

@chakAs3 chakAs3 self-requested a review December 22, 2024 16:48
Comment on lines 88 to 91
if (nuxt.options.dev) {
// Enable runtimeCompiler for Vue to support templates in stories
nuxt.options.vue.runtimeCompiler = true
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it working cause when i tested the custom template stories on showcase example, was not rendering, actually in my last PR #830 , i added resolver to Vite configuration to alias "vue" to "vue/dist/vue.esm-bundler.js

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know if what i did still necessary after this PR

@tobiasdiez tobiasdiez changed the title fix: automatically enable Vue runtime compiler to support Vue templates and decorators in stories chore: add example for using decorators in stories Dec 27, 2024
@tobiasdiez tobiasdiez changed the title chore: add example for using decorators in stories chore: add test for using decorators in stories Dec 27, 2024
@tobiasdiez tobiasdiez merged commit 3378090 into nuxt-modules:main Dec 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants