Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Vite configs to include lodash/kebabCase in optimizeDeps #715

Merged
merged 1 commit into from
Jul 13, 2024
Merged

fix: update Vite configs to include lodash/kebabCase in optimizeDeps #715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions packages/storybook-addon/src/preset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,20 @@ function mergeViteConfig(
extendedConfig.plugins = plugins
// Storybook adds 'vue' as dependency that should be optimized, but nuxt explicitly excludes it from pre-bundling
// Prioritize `optimizeDeps.exclude`. If same dep is in `include` and `exclude`, remove it from `include`
extendedConfig.optimizeDeps!.include =
extendedConfig.optimizeDeps!.include!.filter(
(dep) => !extendedConfig.optimizeDeps!.exclude!.includes(dep),
extendedConfig.optimizeDeps = extendedConfig.optimizeDeps || {}
extendedConfig.optimizeDeps.include =
extendedConfig.optimizeDeps.include || []
extendedConfig.optimizeDeps.include =
extendedConfig.optimizeDeps.include.filter(
(dep) => !extendedConfig.optimizeDeps?.exclude?.includes(dep),
)

// Add lodash/kebabCase, since it is still a cjs module
// Imported in https://github.com/storybookjs/storybook/blob/480359d5e340d97476131781c69b4b5e3b724f57/code/renderers/vue3/src/docs/sourceDecorator.ts#L18
extendedConfig.optimizeDeps.include.push(
'@nuxtjs/storybook > @storybook-vue/nuxt > @storybook/vue3 > lodash/kebabCase',
)

return mergeConfig(extendedConfig, {
// build: { rollupOptions: { external: ['vue', 'vue-demi'] } },
define: {
Expand Down Expand Up @@ -237,6 +247,7 @@ export const viteFinal: StorybookConfig['viteFinal'] = async (
// Write all vite configs to logs
const fs = await import('node:fs')
fs.mkdirSync(join(options.outputDir, 'logs'), { recursive: true })
console.debug(`Writing Vite configs to ${options.outputDir}/logs/...`)
fs.writeFileSync(
join(options.outputDir, 'logs', 'vite-storybook.config.json'),
stringify(storybookViteConfig, { space: ' ' }),
Expand Down