-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: rewrite with improvements #30
Conversation
Hoping this PR goes out soon! 🤞🤞🤞 @danielroe @pi0 i'll buy you both a beer 😝 |
Hi @danielroe @pi0, is there any plan to merge this PR on future? I'm facing the issue with |
Is there any movement for this? We'd love to see that sooner - for our APP see all chunks preloaded is really a blocker. |
@danielroe is working on final rewrite items to release as a major version 🚀 |
Description
This PR ended up being a little more than I had intended. In short, it:
shouldPrefetch
publicPath
to a function (buildAssetsURL
) that is responsible for returning the public path of an asset - currently on rendererContext but it could easily be moved to ssrContext if we want per-request capability_dynamicEntrypoints
cacherenderResourceHeaders
)Closes #28, resolves #20, resolves #24.
Breaking changes
shouldPrefetch
andshouldPreload
now have a different function type:(resource: ParsedResource) => boolean
createBundleRunner
integration has been removednormalizeClientManifest
which can be imported fromvue-bundle-renderer/legacy
)clientManifest
andpublicPath
options can no longer be provided tocreateRenderer