-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update module #48
chore: update module #48
Conversation
ricardogobbosouza
commented
Jul 14, 2019
•
edited
Loading
edited
- Increase coverage
- Update badges
- Add commitlint
- Add husky
Codecov Report
@@ Coverage Diff @@
## next #48 +/- ##
=========================================
+ Coverage 81.81% 100% +18.18%
=========================================
Files 1 1
Lines 33 33
Branches 7 7
=========================================
+ Hits 27 33 +6
+ Misses 6 0 -6
Continue to review full report at Codecov.
|
ye, @galvez maybe u have idea why fibers fails? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @ricardogobbosouza :)
LGTM but what about the fibers
thing ? Should we let treeShake: false
for test purposes for now ?
@ricardogobbosouza Is this PR ready to be merged ? |
Hi @kevinmarrec |
@kevinmarrec it's ready |
Thanks @ricardogobbosouza ! |
@ricardogobbosouza Tests ( Any ideas ? |
@kevinmarrec |
@ricardogobbosouza |
Exactly, should not run, nor launch error silently. |