Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update module #48

Merged
merged 15 commits into from
Jul 22, 2019
Merged

chore: update module #48

merged 15 commits into from
Jul 22, 2019

Conversation

ricardogobbosouza
Copy link
Member

@ricardogobbosouza ricardogobbosouza commented Jul 14, 2019

  • Increase coverage
  • Update badges
  • Add commitlint
  • Add husky

@codecov
Copy link

codecov bot commented Jul 14, 2019

Codecov Report

Merging #48 into next will increase coverage by 18.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             next    #48       +/-   ##
=========================================
+ Coverage   81.81%   100%   +18.18%     
=========================================
  Files           1      1               
  Lines          33     33               
  Branches        7      7               
=========================================
+ Hits           27     33        +6     
+ Misses          6      0        -6
Impacted Files Coverage Δ
lib/module.js 100% <0%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ee5990...1cc15d4. Read the comment docs.

package.json Outdated Show resolved Hide resolved
test/module.test.js Show resolved Hide resolved
test/module.test.js Outdated Show resolved Hide resolved
@ricardogobbosouza ricardogobbosouza changed the title Improvements chore: update module Jul 16, 2019
@galvez
Copy link

galvez commented Jul 18, 2019

@pi0 @aldarund should we bump to v2.0.0-beta.8 too?

@aldarund
Copy link
Member

ye, @galvez maybe u have idea why fibers fails?

Copy link
Member

@kevinmarrec kevinmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @ricardogobbosouza :)

LGTM but what about the fibers thing ? Should we let treeShake: false for test purposes for now ?

@kevinmarrec
Copy link
Member

@ricardogobbosouza Is this PR ready to be merged ?

@ricardogobbosouza
Copy link
Member Author

Hi @kevinmarrec
Skipped test for now
I will resolve the conflicts and it's ready to be merged

@ricardogobbosouza
Copy link
Member Author

@kevinmarrec it's ready

@kevinmarrec kevinmarrec merged commit c13fd8e into nuxt-community:next Jul 22, 2019
@kevinmarrec
Copy link
Member

Thanks @ricardogobbosouza !

@kevinmarrec
Copy link
Member

kevinmarrec commented Jul 22, 2019

@ricardogobbosouza Tests (yarn test) seem to be passing but silently output a bunch of errors related to vuetify-loader :
Screenshot from 2019-07-22 17-13-47

Any ideas ?

@ricardogobbosouza
Copy link
Member Author

@kevinmarrec
It is this test da0a868
That's why it was skipped

@kevinmarrec
Copy link
Member

kevinmarrec commented Jul 22, 2019

@ricardogobbosouza
Why is it not skipped locally ? I mean it shouldn't be runned when I do yarn test, right ?

@ricardogobbosouza
Copy link
Member Author

ricardogobbosouza commented Jul 22, 2019

Exactly, should not run, nor launch error silently.
Its a bug of jest jestjs/jest#8379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants