Allow providers params to be overloaded from nuxt.config.js #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pi0
reviewed
Mar 5, 2018
| // Apply provider | ||
| if (ctx.providers[strategy._provider]) { | ||
| ctx.providers[strategy._provider].call(this, strategy, ctx) | ||
| } | ||
|
|
||
| // _scheme property |
There was a problem hiding this comment.
Why should we move this line after provider?
There was a problem hiding this comment.
Otherwise when _scheme is not defined in nuxt.config.js for a strategy, it is defaulted to the strategy._name before provider default params are assigned, resulting into provider._scheme value not being applied (since it's supposed to be a default value).
Since strategy._name usually does not refer to an existing scheme, it breaks the module.
There was a problem hiding this comment.
Thanks for provided reasons. Seems reasonable :)
pi0
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
userinfo & scope would need to be alterable.