[FIX] Fixes issue with LDAP pagination #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes nuxsmin#1564 For some reason the method ldap_control_paged_result_response does not update the cookie correctly, so the pagination is not stopped. It probably has a reason that this method is deprecated now... This is a temporary fix until support for php 7.2 is dropped since the new way to paginate is only supported since 7.3: https://www.php.net/manual/en/ldap.examples-controls.php#example-5599
nuxsmin
added a commit
that referenced
this pull request
Jun 25, 2022
* [FIX] Fixes issue with LDAP pagination Co-authored-by: Felix Haase <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1564, don't know how to test this though without ldap server
For some reason the method ldap_control_paged_result_response
does not update the cookie correctly, so the pagination is not stopped.
It probably has a reason that this method is deprecated now...
This is a temporary fix until support for php 7.2 is dropped since the
new way to paginate is only supported since 7.3:
https://www.php.net/manual/en/ldap.examples-controls.php#example-5599