-
Notifications
You must be signed in to change notification settings - Fork 213
Copy to clipboard not working in IE 11 and SysPass 1.2.0.13 #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's weird, because that JavaScript library is the same used in sysPass code. Let me find out what is wrong. |
Yesterday I took a deeper look at the problem and compared the used versions of the JavaScript library and how it is used (compared working the example from the webpage with the implementation/usage in sysPass) - but I haven't found why it is not working in IE... Thanks for trying to find out what is wrong and hopefully you have more luck - but you sure have a much deeper knowledge than I have, so I'm pretty sure that you'll find out what is wrong :) |
Can you give a try to the latest sysPass 2.0-beta release? |
I’ll try the release next week. Thanks for the update.
Von: RubénD [mailto:[email protected]]
Gesendet: Freitag, 13. Jänner 2017 00:12
An: nuxsmin/sysPass <[email protected]>
Cc: davidpsc <XXX>; Author <[email protected]>
Betreff: Re: [nuxsmin/sysPass] Copy to clipboard not working in IE 11 and SysPass 1.2.0.13 (#276)
Can you give a try to the latest sysPass 2.0-beta release?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#276 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AFYLP9rnp2WuGS88xwxcLvE03bApnbvwks5rRrM4gaJpZM4J_kln> . <https://github.com/notifications/beacon/AFYLP9O1_dA-ujhchZtpPfbUATm3N4evks5rRrM4gaJpZM4J_kln.gif>
|
Today I wanted to try the latest sysPass release (RC2) but unfortunately the upgrade of the database doesn't seem to happen. I wanted to update from 1.2.0.13 to 2.0.0.17013001-RC2 and I get the following errors in the PHP error log:
Here's what I did:
I had a look at the wiki page regarding upgrading but there it says that this should happen automatically. What did I do wrong? Have I missed something? |
Hi! It's weird because I've tested the upgrade process from 1.2 version without any issues. There haven't been database upgrades since 1.2.0.2 version and the upgrading process should have started. Is there any XML file in the config directory? |
Hi, There is a config.xml which was automatically created. The file seems ok after a quick look at it. The only thing I noticed is this line: I guess this entry shouldn't be translated? Should it say "disabled"? Edit: I've just seen that this setting is also translated in the old config.php, so I guess this is OK
|
No worries :) The tables are right, but I don't know why the upgrade process didn't take place, and that XML file means that an upgrade step was done. Could you take a look to a version field in the config table? |
The version entry in the config table shows 12013. Should I delete the XML file, rename the config.php.old back to config.php and try it again? |
Regarding your last upgrade process, did you set the directory permissions and owner? |
Are you pointing to index.php URL? |
Yes, after the first try I had a look at the PHP error log and saw that the XML file couldn't be created. So I changed the permissions of the new syspass folder to give the webserver user write permissions. After that I tried it again and the XML file was created. Regarding the URL: I first tried the upgrade calling |
Sorry about "index.php", I was answering form the phone so I forget some data... One question about the XML, is there any "upgradeKey" tag? |
Yes, but it is empty: |
I cleaned the PHP error log right now and called the URL again. The error about missing "plugins" table is gone but the error about "log_level" is still there:
Then this block is written again and again, but bigger (increases by three additional lines each block). This continues until the memory limit is reached. |
Ok, if so the database check didn't take place. Currently, I don't have a testing environment like yours, so the only way to get updated is by applying DB updates manually. This could be done by looking at the "inc/sql" directory, where there are several files that match with the sysPass version which requires an upgrade, so you would need to apply from 1316011001. |
Worth to mention that I've set your DB version in my DB and the upgrade process started |
Sorry, I will work partially, because there are auxiliary upgrades... |
I've now done all SQL updates beginning with 1316011001 but there were some errors. Now there is no HTTP 500 anymore but a blank page. This path is invalid because Is this path stored in the DB? |
About the template, the file name is not stored anywhere, but the path is set in the "inc/Base.php" file. I've made a updating script that performs DB upgrades like a normal upgrade... https://gist.github.com/nuxsmin/950010a3ac12d2a723a1a9fa2d7e01f5 Please, try it out by placing it at the sysPass root dir and pointing your browser to it. Be aware that the XML config file is needed (in its own dir). |
Ok, so I've deleted the new database and made a fresh copy, downloaded upgrade.php and put it in the root directory of the new syspass folder and called it via my brower. Result: HTTP 500 Edit: the config.xml file is still in the config dir |
Oh, I just noticed that "version" (in the config table) now says "12013" and there is also a log entry which says that the DB upgrade was successful |
Right, but the final step in the upgrade process is to send an email, so it wasn't performed because a missing class (not sen in the path). Please comment out the line (with "//"):
and rerun the script. It will save the right DB version. |
I commented out the line but nothing changes. Still HTTP 500 and the same entry in the error log Edit: now the version in the database says "2147483647" |
That is the key!...."2147483647" is the max value for a 32 bit integer, but it should be "20017020401", so your system is not managing 64-bit integers... You could update the config table by issuing:
BUT, the next upgrade will fail too. |
The upgrade has already been done. |
Now you can point to the "index.php" file |
I've executed the query and called index.php but the error persists - I don't have the plugins table. |
Ok, let me think about how to solve the 32bit integer limit issue. |
Could that be the issue? I can try to use the 64bit PHP version if this helps |
Sure, but are you running on a 64bit OS? |
Jup, Windows Server 2012 R2 Standard 64bit |
Hi and sorry for the delay... Today I installed PHP 7.0.16 64bit version and downloaded version 2.0.0.17021601 of sysPass.
The PHP error log says the following:
In the database the filed "version" in the "config" table still says: 12013 If I run a script which just contains "echo PHP_INT_MAX;" it returns now 9223372036854775807. What else is there that I could try? |
Is there anything else I could try regarding the update problem? |
Sorry, for the delay... Could you try out with the latest release?. There have been many improvements on the upgrading process, so it should go fine this time. |
* [MOD] Improved version control. Related #276
So, today I tried the release 2.1.1 (latest release) of sysPass and got a blank page after calling http://localhost/syspass_new/index.php I now have used PHP 7.0.16 64bit NTS to avoid the max integer issue but the upgrade still doesn't work properly it seems. This is the content of the syspass.log file which is created in the config directory:
Everything else (the procedure how I did the update) is the same as mentioned on 31 Jan in this ticket. As I see there are currently a few issues:
Before you ask: the DB user for syspass has all rights granted on the syspass database - so there should be no issue with creating new tables and modifying existing ones. Any idea what still the issue could be? Is there another way to use my existing data with the new sysPass version (export/import)? |
With the latest release the version number issue should be fixed, because the upgrading process checks whether the OS supports big integers or not. You can perform a normal upgrade, so no special script is needed. |
I did a normal upgrade - I didn't use the script. I just said that I now use PHP 7.0.16, initially to avoid the max integer problem but a PHP update is always good so I kept using this version. I downloaded the latest release, expanded the contents in a new directory, modified the permissions, copied the old config.php, called http://localhost/syspass_new/index.php and got a blank page and the log file + config.xml created in the config directory. This is the normal, correct upgrading process isn't it? |
You're right, and it should display the upgrade page. One last question, is there any error in the webserver log?. You could also enable the debug mode in 'inc/Base.php' file. Regards |
I've enabled debug mode now in 'inc/Base.php' but I don't see errors in the PHP error log (except the warnings that are written everytime I use sysPass (old version), something about wrong locale), it just tells me where the log file of sysPass was created. With debug mode I see the following in the browser:
The message Just to note: there is nothing changed in the database. I had a look at the config table and the version was not changed after calling index.php, also there is no new entry in the log table. |
Just for curiosity, what is the version number saved in the sysPass DB? |
12013 |
Ummm, the wrong path could be the issue, because a blank page should never be displayed. There is no other way to upgrade, because the database tables need to be updated for some changes, and your current data won't fit the required constraints. Let me do some tests on a Windows environment like yours, it would be the only way to get it. I'll be back soon. |
Hi, how is the setup going? Could you test the upgrade procedure already? |
Hi,sorry for the late response, I missed your issue among others... Unfortunately, I haven't tested it yet (so busy during this time). Let me some time to get it. |
Hi, another few months passed now - have you found some time to test it yet? |
Hi, I were installing an environment like yours, but some issues deploying the PHP modules made me give it up for a while, because I was a bit busy in that time (working & studying), so I'll give a try shortly. Regards |
Hi, we're still waiting for a solution and would really like to upgrade to the latest sysPass version... |
Here's another (small) issue I've found with SysPass 1.2.0.13: there are these great buttons when looking at a password to instantly copy either username or password to the clipboard. It works very well in Google Chrome (which I always use) but I tried the copy-to-clipboard function in IE 11 and it asked for clipboard permissions (which I granted) but nothing was copied. The clipboard still contained the content that I copied previously.
Can you please have a look at it? One of my colleagues always uses IE (for whatever reason...) and he sure would love to copy the password with just a button click. Maybe have a look at https://clipboardjs.com regarding the implementation - on this website it works for Chrome and IE.
Thank you!
The text was updated successfully, but these errors were encountered: