Unable to extract public IP address from header 'HTTP_X_FORWARDED_FOR'

[jlegido]

sysPass Version

3.2 (321.21011601)
Config: 321.21011601
App: 321.21011601
DB: 321.21011601 

Describe the bug
The application is not taking IP address from header 'HTTP_X_FORWARDED_FOR'

To Reproduce

1. Setup syspass behind a reverse proxy (in my case traefik)
2. Perform a request to the syspass URL
3. Tail the logs

Expected behavior
See IP extracted from header 'HTTP_X_FORWARDED_FOR' in the logs

Found behavior
I can see the private IP from the load balancer (in this case traefik)

Screenshots
N/A

Event log
N/A

Platform (please complete the following information):

• OS: Linux
• OS Debian testing
• Browser Firefox

Additional context
I know that I can replace the logged IP at apache level, but I need to set the IP to features like:

• Log an incorrect login attempt
• Block too many requests

So far I'm looking at function getForwardedFor()in lib/SP/Http/Request.php.

Many thanks to all the people involved in this project for their time.

Cheers.

[jlegido]

My quick and dirt hack, just in case somebody else is interested:

Edit lib/SP/Http/Request.php:

vim lib/SP/Http/Request.php

And edit below piece of code:

/*
            $matches = preg_split('/(?<=[\w])+,\s?/i',
                $xForwarded,
                -1,
                PREG_SPLIT_NO_EMPTY);

            if (count($matches) > 0) {
                return $matches;
            }
*/
        return array($_SERVER["HTTP_X_FORWARDED_FOR"]);

[nuxsmin]

Hello,

it seems that this header wasn't parsed correctly. Thanks for the feedback!

Regards

[zmiguelb]

Hello,
Nice work everyone with syspass, really good tool.

Please can you re-open this issue.

The name of the header in php is "HTTP_X_FORWARDED_FOR" however the header itself is "X_FORWARDED_FOR" without the "HTTP_". This is what is causing the issue.

The php function used in /var/www/html/sysPass/lib/SP/Http/Request.php should be changed from this:

185: $xForwarded = $this->headers->get('HTTP_X_FORWARDED_FOR');
491: $forwardedHost = $this->getHeader('HTTP_X_FORWARDED_HOST');
492: $forwardedProto = $this->getHeader('HTTP_X_FORWARDED_PROTO');

to this:

185: $xForwarded = $this->headers->get('X_FORWARDED_FOR');
491: $forwardedHost = $this->getHeader('X_FORWARDED_HOST');
492: $forwardedProto = $this->getHeader('X_FORWARDED_PROTO');

@nuxsmin

Kind regards,
zmiguelb