Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password generator crashes when not selecting Letters #1641

Closed
lavita-com opened this issue Jan 14, 2021 · 1 comment
Closed

Password generator crashes when not selecting Letters #1641

lavita-com opened this issue Jan 14, 2021 · 1 comment
Labels

Comments

@lavita-com
Copy link

lavita-com commented Jan 14, 2021

sysPass Version
3.1 (310.19081801)

Describe the bug
When Selecting 'Include Uppercase' while 'Include Letters' is not selected in the Password generator, the Website crashes.
This Only Affects the Browser used.

To Reproduce
Steps to reproduce the behavior:

  1. Click 'New Account'
  2. Edit Password Complexity
  3. Deselect 'Include Letters'
  4. Accept
  5. Generate Password
  6. Website Freezes

Expected behavior
A Password not containing Lowercase Letters should be generated

Screenshots
image

Platform:
Google Chrome 87 on Windows 10 20H2
Syspass running on Ubuntu 18.04

Additional context
According to this Line:

if (this.config.complexity.uppercase) {

Uppercase Letters will be ignored if Lowercase Letters are not Selected.

However This Line:

if (password.config.complexity.uppercase) {

Will check Uppercase even if there are no Lowercase Letters, Resulting in an Infinite Loop.
} while (!checkComplexity(outPassword));

Thank you for your Time.

nuxsmin added a commit that referenced this issue Jan 19, 2021
…pped. Thanks to @blabllavita . Closes #1641

Signed-off-by: Rubén D <[email protected]>
@nuxsmin
Copy link
Owner

nuxsmin commented Mar 13, 2021

Hello,

this issue was solved in latest release. Thanks for the feedback!

Regards

Fernand0S pushed a commit to Fernand0S/sysPass that referenced this issue Sep 19, 2021
…pped. Thanks to @blabllavita . Closes nuxsmin#1641

Signed-off-by: Rubén D <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants