Subscription send only to others

[Stevemoretz]

• Added or updated tests
• Documented user facing changes
• Updated CHANGELOG.md

A fix for #2293

Changes

Subscriptions can now be filtered via $subscriber->socket_id and request()->header("x-socket-id"), which is similar to what https://laravel.com/docs/9.x/broadcasting#only-to-others does.

Breaking changes

Nope.

[spawnia]

Can you add a test?

Also, please update docs/master and do not change docs/5

[Stevemoretz]

Can you add a test?

Also, please update docs/master and do not change docs/5

Thanks for reviewing this and sorry about the docs, fixed.

I couldn't find any tests for filtering if there is one please tell me where it is then I probably can write a test for this based on that

[spawnia]

Not sure if there are any tests for it. Try adding something in https://github.com/nuwave/lighthouse/tree/master/tests/Integration/Subscriptions.

[Stevemoretz]

Not sure if there are any tests for it. Try adding something in https://github.com/nuwave/lighthouse/tree/master/tests/Integration/Subscriptions.

Thanks that's ok, I'll write one for storage of socket_id that should be good enough.

[Stevemoretz]

Not sure if there are any tests for it. Try adding something in https://github.com/nuwave/lighthouse/tree/master/tests/Integration/Subscriptions.

All done test was added too, tested locally all passed, did cs-fixer and php stan locally no errors.

The errors in the CI seem to be unrelated to the commits you might wanna check on them.

[spawnia]

https://github.com/nuwave/lighthouse/actions/runs/4175774729/jobs/7231159976 is definitely related.

[Stevemoretz]

https://github.com/nuwave/lighthouse/actions/runs/4175774729/jobs/7231159976 is definitely related.

Sure you're right, I don't get that locally different php version or dependencies maybe

/**
     * X-Socket-ID header passed on the subscription query.
     */
    public string|array|null $socket_id;

This would fix it for php 8 I think? But it will break it for php 7, what do you suggest? Would this fix it for all versions? Works for me:

    /**
     * X-Socket-ID header passed on the subscription query.
     * @var string|null|array<mixed>
     */
    public $socket_id;

I'm not really good with different php versions yet I usually use one

[Stevemoretz]

@spawnia Yep that fixed it, the rest is all:

Error: Your requirements could not be resolved to an installable set of packages.

eg: https://github.com/nuwave/lighthouse/actions/runs/4176052100/jobs/7231826956

[spawnia]

good test

[spawnia]

Merging master should fix CI.

[Stevemoretz]

@spawnia Thanks for working on this with me I enjoy doing PRs with you!

[spawnia]

Thanks for the contribution!