Throw GraphQL error when ModelNotFoundException is thrown in CanDirective #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spawnia
reviewed
Mar 9, 2020
spawnia
reviewed
Mar 9, 2020
spawnia
reviewed
Mar 9, 2020
spawnia
pushed a commit
that referenced
this pull request
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Catch
ModelNotFoundExceptioninCanDirectiveand instead throwGraphQL\Error\Error.Also improved a few tests with GraphQL errors.
Breaking changes
Using
@canno longer throwsModelNotFoundExceptionwhen model is not found. Instead the object returns as null, and a GraphQL error is sent. Status code is also changed to 200.