skip rector for proto generated files

nuwave · Dec 4, 2023 · f573b74 · f573b74
1 parent 0d4d55f
commit f573b74
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 15 deletions.
diff --git a/.github/workflows/proto.yml b/.github/workflows/proto.yml
@@ -10,8 +10,6 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-        with:
-          ref: ${{ github.head_ref }}
 
       - uses: shivammathur/setup-php@v2
         with:
@@ -29,14 +27,7 @@ jobs:
           mv proto-tmp/Nuwave/Lighthouse/Tracing/FederatedTracing/Proto src/Tracing/FederatedTracing/Proto
           rm -rf proto-tmp
 
-      # It keeps changing things three times
-      - run: |
-          vendor/bin/rector process && vendor/bin/php-cs-fixer fix
-          vendor/bin/rector process && vendor/bin/php-cs-fixer fix
-          vendor/bin/rector process && vendor/bin/php-cs-fixer fix
-
-      - run: git pull
-        if: github.head_ref != ''
+      - run: vendor/bin/php-cs-fixer fix
 
       - uses: stefanzweifel/git-auto-commit-action@v5
         with:

diff --git a/Makefile b/Makefile
@@ -76,7 +76,4 @@ proto: up
 	${dcphp} rm -rf src/Tracing/FederatedTracing/Proto
 	${dcphp} mv proto-tmp/Nuwave/Lighthouse/Tracing/FederatedTracing/Proto src/Tracing/FederatedTracing/Proto
 	${dcphp} rm -rf proto-tmp
-	# It keeps changing things three times
-	$(MAKE) fix
-	$(MAKE) fix
-	$(MAKE) fix
+	$(MAKE) php-cs-fixer
diff --git a/buf.gen.yaml b/buf.gen.yaml
@@ -1,4 +1,3 @@
-# buf.gen.yaml
 version: v1
 managed:
   enabled: true

diff --git a/rector.php b/rector.php
@@ -39,6 +39,7 @@
         PHPUnitSetList::REMOVE_MOCKS,
     ]);
     $rectorConfig->skip([
+        __DIR__ . '/src/Tracing/FederatedTracing/Proto',
         __DIR__ . '/tests/database/migrations', // Does not fit autoloading standards
         __DIR__ . '/tests/LaravelPhpdocAlignmentFixer.php', // Copied from Laravel
         CallableThisArrayToAnonymousFunctionRector::class, // Callable in array form is shorter and more efficient