automation: issue #30 resume visibility + ledger PR-summary formatter - #55
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughLoads the SDLC run ledger after computing the resume plan in the CLI run command and prints a formatted PR-comment summary to stderr; the state module adds SDLC ledger types, a fallible Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/cli/run.rs`:
- Around line 93-95: The current use of the `?` operator on
`load_sdlc_run_ledger(project_root, &ctx.run_id)?` causes `tt run --resume` to
abort on ledger-read errors; change this to a best-effort attempt that logs a
warning and continues on failure. Replace the `if let Some(ledger) =
load_sdlc_run_ledger(...)? { ... }` with code that calls
`load_sdlc_run_ledger(...)` and matches on the Result: on Ok(Some(ledger)) call
`eprintln!("{}", sdlc_pr_comment_summary(&ledger))`, on Ok(None) do nothing, and
on Err(err) print a warning (e.g., to stderr) that includes `err` and continue
without returning an error. Ensure you reference `load_sdlc_run_ledger` and
`sdlc_pr_comment_summary` so the change is applied around those symbols.
In `@src/state/mod.rs`:
- Around line 207-238: Change the public helper sdlc_pr_comment_summary to
return Result<String, TuttiError> instead of String: update its signature to pub
fn sdlc_pr_comment_summary(ledger: &SdlcRunLedgerRecord) -> Result<String,
TuttiError>, build the output as before but replace any direct returns of out
with Ok(out) (including the early "No transitions recorded yet." branch), and
return Ok(out.trim_end().to_string()) at the end; also update any callers to
handle the Result (propagate with ? or map_err to TuttiError as appropriate).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: a7f35598-5134-4b6a-a74b-9bd262750a3b
📒 Files selected for processing (2)
src/cli/run.rssrc/state/mod.rs
|
Addressed the two CodeRabbit blockers in commit acf7735.
Validation: |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Dismissing stale bot CHANGES_REQUESTED after commit acf7735 and successful CodeRabbit/check suite.
|
Automation update: dismissed stale CodeRabbit CHANGES_REQUESTED review after commit acf7735 and green checks. Current merge blocker is branch protection requiring 1 approving review (required_approving_review_count=1). |
|
Follow-up fix pushed in b90afb2:\n- added rustdoc for SDLC ledger summary public APIs to improve docstring coverage\n- updated PR description with explicit Versioning section and SemVer choice\n\n@coderabbitai review |
|
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
wren-nutthouse
left a comment
wren-nutthouse
left a comment
There was a problem hiding this comment.
Reviewed automation updates: ledger summary handling, error-tolerant resume path, and docs/versioning notes look good. Approving to unblock merge.
|
Automation check (v0.3 readiness run): all checks green, reviewDecision=APPROVED, and no actionable CodeRabbit findings remain. Merge is still blocked by base-branch policy ( reports: "the base branch policy prohibits the merge`). |
…choir runs (#71) * feat(health): add startup grace window to wait_for_agent_idle (#67) Prevent fresh prompt steps from falsely completing before the agent has consumed the prompt. The startup grace period (default 30s) gates completion detection until real working activity is observed. Key changes: - wait_for_agent_idle accepts a startup_grace Duration parameter - AgentStatus::Working counts as activity even without pane hash change, requiring 2+ consecutive polls to avoid flicker false positives - First pane capture no longer counts as a hash "change" - Completion signals before any activity are held until grace expires - "Unravelling" added to claude-code working patterns - startup_grace_secs field threaded through config and automation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs: add 0.3.0 changelog entry for issue #67 and prior unreleased changes Cover startup grace window (#67), persistent memory (#62/#63), merge gate enforcement (#59), permissions suggest (#53), orchestration state machine (#54/#55), and all fixes shipped since 0.2.0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: reduce startup grace to 10s and validate wait settings - Reduce DEFAULT_STARTUP_GRACE_SECS from 30 to 10 so the completion-before-activity path fires before typical wait timeouts - Validate that wait_timeout_secs/startup_grace_secs are only set when wait_for_idle is true, failing fast with actionable guidance Addresses CodeRabbit feedback on PR #71. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 participants
Summary
tt run --resume <run_id>if a ledger existssdlc_pr_comment_summaryhelper to render ledger transitions as reusable PR-comment textValidation
Versioning
Refs #30
Summary by CodeRabbit