Fix daily reminder time parsing issue in Canada #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me parsing issues in Canada
jorpaspr
reviewed
Jul 24, 2023
app/src/main/java/org/nutritionfacts/dailydozen/model/pref/UpdateReminderPref.java
Show resolved
Hide resolved
|
Closing this PR as the description is no longer accurate and I've moved the single line change here: #235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue causing daily reminder notifications to not show at the correct time for users in Canada.
The problem is the time "8:00 PM" does not parse correctly in Canada as the locale requires am/pm labels to be in the format "a.m./p.m."