refactor: add nic_list_status to separate the computed values #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
| "subnet_name": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Computed: true, |
There was a problem hiding this comment.
All of this attributes are only computed right?
| @@ -737,7 +813,10 @@ func resourceNutanixVirtualMachineRead(d *schema.ResourceData, meta interface{}) | |||
| if err := d.Set("availability_zone_reference", flattenReferenceValues(resp.Status.AvailabilityZoneReference)); err != nil { | |||
| return fmt.Errorf("error setting availability_zone_reference for Virtual Machine %s: %s", d.Id(), err) | |||
| } | |||
| if err := d.Set("nic_list", flattenNicList(resp.Status.Resources.NicList)); err != nil { | |||
| if err := d.Set("nic_list", flattenNicList(resp.Spec.Resources.NicList)); err != nil { | |||
There was a problem hiding this comment.
If nic_list_status contains the output of the request and nic_list contains the arguments to create the nics, I think you should not set them here nic_list
|
Also, can you add a test case for this? |
Yes I'd already added a test case for subnets/NICs in 1bf461b, let me cherry pick and modify for the new configuration. |
marinsalinas
force-pushed
the
ip-endpoint-status-#12
branch
from
a477780 to
68963db
Compare
marinsalinas
force-pushed
the
ip-endpoint-status-#12
branch
from
68963db to
9eb7f20
Compare
|
Not gonna sign this off until we can try this on the lab environment. |
marinsalinas
force-pushed
the
ip-endpoint-status-#12
branch
6 times, most recently
from
9d2dc6f to
a8f8922
Compare
marinsalinas
force-pushed
the
ip-endpoint-status-#12
branch
from
a8f8922 to
301201a
Compare
yannickstruyf3
pushed a commit
to yannickstruyf3/terraform-provider-nutanix
that referenced
this pull request
Nov 9, 2021
Assign categories to resources nutanix#40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12 #17 #19
We added the nic_list_status attribute (computed) to show all the nic_list with the ip_endpoint_list from the Status object.
You could get the IP address by this: