Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled project resource, tests fixed and issue fixed #146

Merged
merged 3 commits into from
Jun 25, 2020
Merged

Disabled project resource, tests fixed and issue fixed #146

merged 3 commits into from
Jun 25, 2020

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Jun 24, 2020

Added:

  • The project resource was disabled due to it needs some changes to be done.
  • State issue regarding use_hot_add attribute was fixed
  • All the test were test and some with issues were fixed

@PacoDw PacoDw requested review from marinsalinas and coderGo93 June 24, 2020 20:33
@ghost ghost added the size/M label Jun 24, 2020
@ghost ghost added size/XXL and removed size/M labels Jun 24, 2020
marinsalinas
marinsalinas suggested changes Jun 24, 2020
View reviewed changes
@ghost ghost added size/S and removed size/XXL labels Jun 24, 2020
@PacoDw PacoDw requested a review from marinsalinas June 24, 2020 21:21
marinsalinas
marinsalinas approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marinsalinas marinsalinas merged commit 13d49ba into master Jun 25, 2020
@marinsalinas marinsalinas deleted the fix_tests branch June 25, 2020 15:17
yannickstruyf3 pushed a commit to yannickstruyf3/terraform-provider-nutanix that referenced this pull request Nov 9, 2021
@marinsalinas
Merge pull request nutanix#146 from terraform-providers/fix_tests
24739c2 
Disabled project resource, tests fixed and issue fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinsalinas marinsalinas marinsalinas approved these changes

@coderGo93 coderGo93 Awaiting requested review from coderGo93

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PacoDw @marinsalinas