CPU and RAM change does not restart VM automatically

[mritzmann]

Describe the bug
My guest system does not support Hotplug out of the box, so after CPU and RAM adjustment a restart is required. Terraform automatically restarts the affected VM when the size is reduced, but not when the size is increased. This feature was added in PR #75.

Expected behavior
Terraform should restart the affected VM. Or alternatively provide an option to configure this behavior.

Logs
I'll be happy to deliver more if necessary.

Versions (please complete the following information):

• OS: Debian 8.11
• Terraform: v0.11.14
• Nutanix Cluster (Prism Element / AOS): Version 5.10.6 LTS
• Nutanix Prism Central: 5.10.6
• Terraform provider version: v1.0.2, installed with provider "nutanix"

Additional context
I created this issue as a bug, because the behavior has changed, without the possibility to keep the old behavior. So I can't enlarge VMs via Terraform anymore. Or is there a configuration option for it?

[mritzmann]

Build v1.0.2 without Hotplug:

docker run -it golang:1.12 /bin/bash

git checkout -b patch-revert 50863de314994937b0cf822ee63bf11e9c888ca8
git revert 7123f520971114e70accb598347bbbde871f602b
git revert 1ba8002fdbdb6202000c66496adebde451dda5c2
git revert 120d472d33c998e68b8e723a287b1e908babb4ab
git revert 1cc9c6db1124c9519aa1d8c1dff0affcde4f971c
git revert f61aa7364b0c15aa069e82846e5565771141a1db

go get -u github.com/golang/dep/cmd/dep

env CGO_ENABLED=0 GOOS=linux GOARCH=amd64 make build

[coderGo93]

Hello @mritzmann, is this problem still happening on master? If so, can you share the config file without sensitive data so I can test and see what happens, please?

[coderGo93]

Hello @mritzmann , I just tested it seems it worked for me, I changed cpus/memory/sockets and it turns off then it turns on(Reboot) on master but I need your confirmation before this issue is already solved and closed.

[coderGo93]

Hello @mritzmann , I made PR with branch fix-86/79 , a new parameter to force reboot for Cpus/memory changes, so if it's possible you can try it and see if it's ok, please?

[coderGo93]

Hello, I'm going to close because there are not responses from the issuer and it has been added a parameter for this case and merged to master.

[mritzmann]

Hi @coderGo93, thanks for your work. I tested it today with the 1.0 release. Seems to work fine!