refactor: avoid nil assingment in serial port list

nutanix · Apr 16, 2019 · 27b1bb3 · 27b1bb3
1 parent 53a8d0b
commit 27b1bb3
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/nutanix/resource_nutanix_virtual_machine.go b/nutanix/resource_nutanix_virtual_machine.go
@@ -1704,17 +1704,16 @@ func preFillResUpdateRequest(res *v3.VMResources, response *v3.VMIntentResponse)
 	}
 	res.NicList = nold
 
-	spl := make([]*v3.VMSerialPort, len(response.Status.Resources.SerialPortList))
+	var spl []*v3.VMSerialPort
 	if len(response.Status.Resources.SerialPortList) > 0 {
+		spl = make([]*v3.VMSerialPort, len(response.Status.Resources.SerialPortList))
 		for k, v := range response.Status.Resources.SerialPortList {
 			spl[k] = &v3.VMSerialPort{
 				Index:       v.Index,
 				IsConnected: v.IsConnected,
 			}
 
 		}
-	} else {
-		spl = nil
 	}
 	res.SerialPortList = spl