Merge branch 'main' into feat/pbr

.gitignore

@@ -0,0 +1 @@
+nutanix-ncp-*

tests/integration/targets/nutanix_floating_ips/tasks/create_floating_ips.yml

@@ -1,13 +1,32 @@
 ---
-- name: create Floating IP with External Subnet uuid
+- name: Create floating ip with external subnet uuid
   ntnx_floating_ips:
     validate_certs: False
     state: present
-    nutanix_host: "{{ IP }}"
+    nutanix_host: "{{ ip }}"
     nutanix_username: "{{ username }}"
     nutanix_password: "{{ password }}"
+    wait: False
     external_subnet:
-      uuid: "{{external_subnet.subnet_uuiid}}"
+      uuid: "{{ external_subnet.uuid }}"
+  register: result
+  ignore_errors: True
+
+- set_fact:
+    todelete: "{{ todelete + [  result.fip_uuid ] }}"
+##############################################################
+- name: Create floating ip with vpc name and external subnet uuid
+  ntnx_floating_ips:
+    validate_certs: False
+    state: present
+    nutanix_host: "{{ ip }}"
+    nutanix_username: "{{ username }}"
+    nutanix_password: "{{ password }}"
+    external_subnet:
+      uuid: "{{external_subnet.uuid}}"
+    vpc:
+       name: "{{ vpc.name }}"
+    private_ip: "{{ private_ip }}"
   register: result
   ignore_errors: True
 
@@ -16,80 +35,144 @@
     that:
       - result.response is defined
       - result.response.status.state == 'COMPLETE'
-    fail_msg: " Unable to create  Floating ip "
-    success_msg: "  Floating ip created successfully "
+    fail_msg: " Unable to create floating ip with vpc "
+    success_msg: " Floating ip with vpc name and external subnet uuid created successfully "
 
 - set_fact:
     todelete: "{{ todelete + [  result.fip_uuid ] }}"
+##########################################################
+- name: Delete all created floating ips
+  ntnx_floating_ips:
+    state: absent
+    nutanix_host: "{{ ip }}"
+    nutanix_username: "{{ username }}"
+    nutanix_password: "{{ password }}"
+    validate_certs: false
+    fip_uuid: "{{ item }}"
+  register: result
+  loop: "{{ todelete }}"
 
+- set_fact:
+    todelete: []
+###########################################################
+- name: Create floating ip with external subnet name
+  ntnx_floating_ips:
+    validate_certs: False
+    state: present
+    nutanix_host: "{{ ip }}"
+    nutanix_username: "{{ username }}"
+    nutanix_password: "{{ password }}"
+    wait: False
+    external_subnet:
+      name: "{{ external_subnet.name }}"
+  register: result
+  ignore_errors: True
 
-- name: create Floating IP with vpc Name with external subnet uuid
+- set_fact:
+    todelete: "{{ todelete + [  result.fip_uuid ] }}"
+############################################################
+- name: Create floating ip with vpc uuid and external subnet name
   ntnx_floating_ips:
     validate_certs: False
     state: present
-    nutanix_host: "{{ IP }}"
+    nutanix_host: "{{ ip }}"
     nutanix_username: "{{ username }}"
     nutanix_password: "{{ password }}"
     external_subnet:
-      uuid: "{{external_subnet.subnet_uuiid}}"
+      name: "{{ external_subnet.name }}"
     vpc:
-       name: "{{vpc.vpc_name}}"
-    private_ip: "{{private_ip}}"
+       uuid: "{{ vpc.uuid }}"
+    private_ip: "{{ private_ip }}"
   register: result
   ignore_errors: True
+
+- set_fact:
+    todelete: "{{ todelete + [  result.fip_uuid ] }}"
+############################################################
+- name: Delete all created floating ips
+  ntnx_floating_ips:
+    state: absent
+    nutanix_host: "{{ ip }}"
+    nutanix_username: "{{ username }}"
+    nutanix_password: "{{ password }}"
+    validate_certs: false
+    fip_uuid: "{{ item }}"
+  register: result
+  loop: "{{ todelete }}"
+  ignore_errors: True 
+
+- set_fact:
+    todelete: []
+##########################################################
+- name: Create floating ip with external subnet and vm name
+  ntnx_floating_ips:
+    validate_certs: False
+    state: present
+    nutanix_host: "{{ ip }}"
+    nutanix_username: "{{ username }}"
+    nutanix_password: "{{ password }}"
+    external_subnet:
+      name: "{{ vm_subnet_name }}"
+    vm:
+      name: "{{ vm.name }}"
+  ignore_errors: True
+  register: result
 
 - name: Creation Status
   assert:
     that:
       - result.response is defined
       - result.response.status.state == 'COMPLETE'
-    fail_msg: " Unable to create  Floating ip with vpc "
-    success_msg: "  Floating ip with vpc created successfully "
-
+    fail_msg: " Unable to create floating ip with vm"
+    success_msg: " Floating ip with external subnet and vm created successfully "
 
-- name: Delete the Floating IP with vpc Name with external subnet uuid
+- set_fact:
+    todelete: "{{ todelete + [  result.fip_uuid ] }}"
+##########################################################
+- name: Delete all created floating ips
   ntnx_floating_ips:
     state: absent
-    nutanix_host: "{{ IP }}"
+    nutanix_host: "{{ ip }}"
     nutanix_username: "{{ username }}"
     nutanix_password: "{{ password }}"
     validate_certs: false
-    fip_uuid: "{{result.fip_uuid}}"
+    fip_uuid: "{{ item }}"
   register: result
-  ignore_errors: True
-
-
-- name: create Floating IP with External Subnet with vm
+  loop: "{{ todelete }}"
+  ignore_errors: True 
+
+- set_fact:
+    todelete: []
+#########################################################
+- name: Create floating ip with external subnet and vm uuid
   ntnx_floating_ips:
     validate_certs: False
     state: present
-    nutanix_host: "{{ IP }}"
+    nutanix_host: "{{ ip }}"
     nutanix_username: "{{ username }}"
     nutanix_password: "{{ password }}"
     external_subnet:
-      name: "{{vm_subnet_name}}"
+      name: "{{ vm_subnet_name }}"
     vm:
-      name: "{{vm.vm_name}}"
+      uuid: "{{ vm.uuid }}"
   ignore_errors: True
-
   register: result
 
 - name: Creation Status
   assert:
     that:
       - result.response is defined
       - result.response.status.state == 'COMPLETE'
-    fail_msg: " Unable to create  Floating ip with vm"
-    success_msg: "  Floating ip created successfully with vm "
+    fail_msg: " Unable to create floating ip with vm"
+    success_msg: " Floating ip with external subnet and vm created successfully "
 
 - set_fact:
     todelete: "{{ todelete + [  result.fip_uuid ] }}"
-
-
-- name: Delete all Created Floating ips
+###########################################################
+- name: Delete all created floating ips
   ntnx_floating_ips:
     state: absent
-    nutanix_host: "{{ IP }}"
+    nutanix_host: "{{ ip }}"
     nutanix_username: "{{ username }}"
     nutanix_password: "{{ password }}"
     validate_certs: false

tests/integration/targets/nutanix_floating_ips/tasks/main.yml

@@ -1,3 +1,3 @@
 - block:
     - import_tasks: "create_floating_ips.yml"
-
+    - import_tasks: "negative_scenarios.yml"

tests/integration/targets/nutanix_floating_ips/tasks/negative_scenarios.yml

@@ -0,0 +1,99 @@
+- debug:
+      msg: "Started Negative Creation Cases"
+- name: Create floating ip with unknown external subnet name
+  ntnx_floating_ips:
+    validate_certs: False
+    state: present
+    nutanix_host: "{{ ip }}"
+    nutanix_username: "{{ username }}"
+    nutanix_password: "{{ password }}"
+    external_subnet:
+      name: "external_subnet"
+  register: result
+  ignore_errors: True
+
+- name: Creation Status
+  assert:
+    that:
+      - result.failed==True
+      - result.msg=="Failed generating floating_ip spec"
+    success_msg: ' Success: returned error as expected '
+#################################################################
+- name: Create floating ip with unknown external subnet uuid
+  ntnx_floating_ips:
+    validate_certs: False
+    state: present
+    wait: false
+    nutanix_host: "{{ ip }}"
+    nutanix_username: "{{ username }}"
+    nutanix_password: "{{ password }}"
+    external_subnet:
+      uuid: 54e295c3-16d3-49de-96ba-b921948b3a
+  register: result
+  ignore_errors: True
+
+- name: Creation Status
+  assert:
+    that:
+      - result.status_code==422
+    success_msg: ' Success: returned error as expected '
+###############################################################
+- name: Create floating ip with unknown vpc
+  ntnx_floating_ips:
+    validate_certs: False
+    state: present
+    nutanix_host: "{{ ip }}"
+    nutanix_username: "{{ username }}"
+    nutanix_password: "{{ password }}"
+    external_subnet:
+      name: "{{ external_subnet.name}}"
+    vpc:
+       name: vpc
+    private_ip: "{{ private_ip }}"
+  register: result
+  ignore_errors: True
+
+- name: Creation Status
+  assert:
+    that:
+      - result.failed==True
+      - result.msg=="Failed generating floating_ip spec"
+    success_msg: ' Success: returned error as expected '
+###############################################################
+- name: Create floating ip with unknown vpc uuid
+  ntnx_floating_ips:
+    validate_certs: False
+    state: present
+    nutanix_host: "{{ ip }}"
+    nutanix_username: "{{ username }}"
+    nutanix_password: "{{ password }}"
+    external_subnet:
+      name: "{{ external_subnet.name }}"
+    vpc:
+       uuid: 471181f8-eb2d-4303-9a61-6b25a1b3
+    private_ip: "{{ private_ip }}"
+  register: result
+  ignore_errors: True
+
+- name: Creation Status
+  assert:
+    that:
+      - result.status_code==422
+    success_msg: ' Success: returned error as expected '
+##############################################################
+- name: Delete floating ip with unknown uuid
+  ntnx_floating_ips:
+    state: absent
+    nutanix_host: "{{ ip }}"
+    nutanix_username: "{{ username }}"
+    nutanix_password: "{{ password }}"
+    validate_certs: false
+    fip_uuid: 5
+  register: result
+  ignore_errors: True
+
+- name: Creation Status
+  assert:
+    that:
+      - result.status_code==400
+    success_msg: ' Success: returned error as expected '

tests/integration/targets/nutanix_floating_ips/vars/main.yml

@@ -1,15 +1,21 @@
-IP: 10.44.76.88
+ip: 10.44.76.88
 username: admin
 password: Nutanix.123
+
 external_subnet:
-  subnet_name: ET_7
-  subnet_uuiid: 54e295c3-16d3-49de-96ba-b921948b3a4d
+  name: Ext-Nat
+  uuid: 581b6d25-4064-4cd0-b8ef-5aa0f3b98700
+
 vpc:
-  vpc_name: ET_8
-  vpc_uuiid: 471181f8-eb2d-4303-9a61-6b25a1b3553e
+  name: ET_8
+  uuid: 55c50dad-7b45-4067-9ee9-97c0275a69f5
+
 vm:
-  vm_name: ET_11
-  vm_uuid: 83c9c094-2b18-4e65-bf6f-234640e07bc0
-private_ip: 192.168.1.153
+  name: ET_11
+  uuid: a34604ae-a092-4994-ae29-50c906da41fa
+
+private_ip: 192.168.0.10
+
+vm_subnet_name: Ext-Nat
+
 todelete: []
-vm_subnet_name: Prod-NAT