fix: image registries with no credentials but with a CA #927
+115
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
force-pushed
the
dkoshkin/fix-registries-with-no-credentials-but-with-ca
branch
from
88f104f
to
794b055
Compare
|
|
dkoshkin
force-pushed
the
dkoshkin/fix-registries-with-no-credentials-but-with-ca
branch
from
68c0154
to
e3b4e0e
Compare
dkoshkin
force-pushed
the
dkoshkin/fix-registries-with-no-credentials-but-with-ca
branch
from
e3b4e0e
to
a7279d4
Compare
jimmidyson
reviewed
Sep 30, 2024
pkg/handlers/generic/mutation/imageregistries/credentials/inject.go
Outdated
Show resolved
Hide resolved
| } | ||
| } else { | ||
| return false, fmt.Errorf("invalid image registry: %s: %w", config.URL, ErrCredentialsNotFound) | ||
| if config.Mirror || config.HasCACert { |
There was a problem hiding this comment.
Why not move this logic into requiresStaticCredentials func now?
There was a problem hiding this comment.
I was looking into this some more and I don't really see a way to simplify.
We need to differentiate when requiresStaticCredentials is true and when config.Mirror || config.HasCACert vs nothing is set there.
Expect image registries with no credentials but with a CA to still work.
dkoshkin
force-pushed
the
dkoshkin/fix-registries-with-no-credentials-but-with-ca
branch
from
a7279d4
to
890d3f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Passing
imageRegistrieswith a CA but without credentials is still a valid configuration and should not error.Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: