build: migrate to devbox tooling #358
Conversation
nutanix-cn-prow-bot
bot
requested review from
deepakm-ntnx and
yannickstruyf3
|
@faiq this has conflicts. could you please fix it. also it would be good to update description with the tests done |
faiq
force-pushed
the
devbox-build
branch
3 times, most recently
from
e55f9ae to
d70f925
Compare
|
/retest |
1 similar comment
|
/retest |
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
faiq
force-pushed
the
devbox-build
branch
2 times, most recently
from
8e80a7a to
1247312
Compare
|
/retest |
faiq
changed the title
|
/test e2e-capx-controller-upgrade |
|
/test e2e-capx-controller-upgrade |
|
/test e2e-k8s-upgrade |
faiq
force-pushed
the
devbox-build
branch
3 times, most recently
from
492c0e1 to
4d62741
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
==========================================
- Coverage 15.24% 13.70% -1.55%
==========================================
Files 18 17 -1
Lines 1207 1197 -10
==========================================
- Hits 184 164 -20
- Misses 1023 1033 +10 ☔ View full report in Codecov by Sentry. |
faiq
force-pushed
the
devbox-build
branch
2 times, most recently
from
74c9a21 to
af28206
Compare
thunderboltsid
requested review from
deepakm-ntnx,
dlipovetsky,
supershal and
thunderboltsid
supershal
left a comment
supershal
left a comment
There was a problem hiding this comment.
Tested latest changes locally. Thank you.
|
/retest |
|
@faiq: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-capx-controller-upgrade |
thunderboltsid
left a comment
thunderboltsid
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/woof
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepakm-ntnx, faiq, supershal, thunderboltsid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 participants
What this PR does / why we need it:
This PR moves to using devbox both in CI and locally to manage binary installations. The changes in this PR are as follows:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):This makes local development and CI more consistent.
How Has This Been Tested?:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output
The CI has previously passed and runs properly.
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: