Modifier keys are not properly released.

[ccorcos]

Version

"@nut-tree/nut-js": "^1.7.0",

Short overview

I'm running this program:

import * as nut from "@nut-tree/nut-js"

async function main() {
	await nut.sleep(2000)
	await nut.keyboard.pressKey(nut.Key.LeftSuper, nut.Key.LeftShift, nut.Key.P)
	await nut.keyboard.releaseKey(nut.Key.LeftSuper, nut.Key.LeftShift, nut.Key.P)

	await nut.keyboard.type("Open Document")

	await nut.keyboard.pressKey(nut.Key.Enter)
	await nut.keyboard.releaseKey(nut.Key.Enter)
}

main()

And in javascript (Chrome), I'm logging the document keydown events:

document.addEventListener("keydown", event => {
		console.log(
			"keydown",
			event.key,
			event.shiftKey,
			event.metaKey,
			event.altKey,
			event.ctrlKey
		)
});

And the result: Shift and Meta keys are still held down when typing. Although they turn off after enter...

Issue occurs on

• Virtual machine
• Docker container
• Dev/Host system -- MacOS

Detailed error description

Steps to reproduce error

Additional content

Please provide any (mandatory) additional data to reproduce the error (Dockerfiles etc.)

[theminor]

For my system, releaseKey() doesn't seem to be working for any keys. The following code results in the S Key being held down and never released:

const { sleep, keyboard, Key } = require("@nut-tree/nut-js");

async function go() {
	await sleep(2000)
	await keyboard.pressKey(Key.S);
	await sleep(2000)
	await keyboard.releaseKey(Key.S);
}

go();

Using nut-js version 1.7.0 on Windows 10.

[s1hofmann]

Hm, I initially suspected a timing issue, but if also happens with the additional sleep I doubt that. Will have to investigate further

[s1hofmann]

Removed it from the 2.0.0 milestone since fixing this issue won’t necessarily require a major release

[github-actions]

This issue is stale because it has been open for 30 days with no activity.

[ccorcos]

Hmm. Still an issue for me...

[s1hofmann]

@ccorcos @theminor Would you be available to verify the latest snapshot solves #264 and #273?

npm i @nut-tree/nut-js@next