-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance report course error button visibility during coursereg/course update periods #3963
base: master
Are you sure you want to change the base?
Enhance report course error button visibility during coursereg/course update periods #3963
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@junnjiee16 is attempting to deploy a commit to the modsbot's projects Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3963 +/- ##
==========================================
+ Coverage 54.52% 54.97% +0.44%
==========================================
Files 274 276 +2
Lines 6076 6332 +256
Branches 1455 1551 +96
==========================================
+ Hits 3313 3481 +168
- Misses 2763 2851 +88 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks! Would be great if we could update the following page to reduce traffic into [email protected]. Personally, would be great if we either increased the visibility/importance of the reference to the "Report Error" button, or to embed a button just for users to click here!
https://nusmods.com/faq (Relevant file: /website/src/views/static/FaqContainer.tsx
)
f2d71c7
to
9a6c34e
Compare
Hi @jloh02, thank you for reviewing! I modified
Regarding the comment above, I assume you wanted something like this? |
Context
resolves #3784
Implementation
Error button in the module page will more prominent and a reminder text will be shown below the button if any of these conditions are met (as requested in #3784)
enableAnnouncements
andkey
variables inAnnouncements.tsx
New button look:
Other Information
I'm new to contributing to open source in general, so do let me know if anything can be done better.