Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance report course error button visibility during coursereg/course update periods #3963

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

junnjiee16
Copy link

@junnjiee16 junnjiee16 commented Jan 7, 2025

Context

resolves #3784

Implementation

Error button in the module page will more prominent and a reminder text will be shown below the button if any of these conditions are met (as requested in #3784)

  1. current date is +/- 2 weeks from CourseReg's round 1 start date (using https://github.com/nusmodifications/nusmods/blob/master/website/src/data/modreg-schedule.json to check for this)
  2. When the relevant announcement is enabled. This is done by checking the enableAnnouncements and key variables in Announcements.tsx

New button look:
Screenshot from 2025-01-07 22-48-36

Other Information

I'm new to contributing to open source in general, so do let me know if anything can be done better.

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 1:12pm

Copy link

vercel bot commented Jan 7, 2025

@junnjiee16 is attempting to deploy a commit to the modsbot's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.97%. Comparing base (988c6fd) to head (9a6c34e).
Report is 78 commits behind head on master.

Files with missing lines Patch % Lines
...rc/views/components/notfications/Announcements.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3963      +/-   ##
==========================================
+ Coverage   54.52%   54.97%   +0.44%     
==========================================
  Files         274      276       +2     
  Lines        6076     6332     +256     
  Branches     1455     1551      +96     
==========================================
+ Hits         3313     3481     +168     
- Misses       2763     2851      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jloh02 jloh02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks! Would be great if we could update the following page to reduce traffic into [email protected]. Personally, would be great if we either increased the visibility/importance of the reference to the "Report Error" button, or to embed a button just for users to click here!

https://nusmods.com/faq (Relevant file: /website/src/views/static/FaqContainer.tsx)

@junnjiee16
Copy link
Author

Hi @jloh02, thank you for reviewing!

I modified Announcements.tsx to export a isNewCourseDataAnnoucement function instead, which returns only boolean.

Looks good thanks! Would be great if we could update the following page to reduce traffic into [email protected]. Personally, would be great if we either increased the visibility/importance of the reference to the "Report Error" button, or to embed a button just for users to click here!

https://nusmods.com/faq (Relevant file: /website/src/views/static/FaqContainer.tsx)

Regarding the comment above, I assume you wanted something like this?
image

Small change but bolded it for extra clarity
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make report course error button more prominent coursereg / course update periods
2 participants