add a warning and a note about changing show_banner
#846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks but I think we shouldn't land this. I think your last PR that put it at the top should suffice for now. |
Member
Author
gotcha 🤞 |
ayax79
pushed a commit
to ayax79/nushell.github.io
that referenced
this pull request
Jun 26, 2024
…/webscrapping` (nushell#846) This PR is part of porting all old scripts nushell#221 and includes only removing already ported modules: - `progress_bar` -> `sourced/progress_bar` - `weather` -> `modules/weather` - `webscrapping` -> `sourced/webscrapping`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to nushell/nushell#8698.
This PR adds a Warning about the already existing
show_banner: truein the default config and a Note about the idea of throwing an error when fields are defined multiple times in a record.