0.107 release notes: Fix extremely minor inconsistency #2028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will update #1999.
The types that are affected by the
into binarychange were listed in the singular form, but the ones that weren't were listed with an "s".In a separate commit, I also reworded the next sentence to avoid code text being directly followed with an "s" (e.g.
records). That form is fine for GitHub comments and such of course, and it looks great when viewing the raw markdown, but IMO the "s" looks too disconnected from what it's attached to when rendered.Here's an example of how that pattern gets rendered on the website: https://www.nushell.sh/book/control_flow.html#if (search for "We can also chain multiple"). There aren't many instances of this on the website (outside of the blog), but I'll wait to see if this is something other people agree with me on before proposing any changes to them.