Fix IPv6 filter workaround

[goll]

Should fix IPv6 filtering(#80), so the workaround shouldn't be needed anymore.

Test playbook used:

- hosts: localhost
  gather_facts: yes
  vars:
    tor_maxips: 3
    tor_v4ips: "{{ ansible_all_ipv4_addresses[0:tor_maxips] | ipv4('address') }}"
    ipv4_count: "{{ tor_v4ips | length }}"
    v6tmp: "{{ ansible_all_ipv6_addresses | ipv6('address') | ipv6('public') }}"
    tor_v6ips: "{{ v6tmp[0:ipv4_count|int] | ipwrap }}"
  tasks:
  - debug: var=tor_v4ips
  - debug: var=ipv4_count
  - debug: var=v6tmp
  - debug: var=tor_v6ips
  - name: setup IP list (1/2)
    set_fact:
      ips:
          ipv4: "{{ item.0 }}"
          ipv6: "{{ item.1 }}"
    with_together:
          - "{{ tor_v4ips }}"
          - "{{ tor_v6ips }}"
    register: iptest
  - debug:
      var: iptest

Test output with 1 local tor_v4ips and 0 public tor_v6ips:

ok: [localhost] => {
    "iptest": {
        "changed": false,
        "msg": "All items completed",
        "results": [
            {
                "_ansible_ignore_errors": null,
                "_ansible_item_label": [
                    "10.0.2.15",
                    null
                ],
                "_ansible_item_result": true,
                "_ansible_no_log": false,
                "ansible_facts": {
                    "ips": {
                        "ipv4": "10.0.2.15",
                        "ipv6": ""
                    }
                },
                "changed": false,
                "failed": false,
                "item": [
                    "10.0.2.15",
                    null
                ]
            }
        ]
    }
}

Test output with 3 local tor_v4ips and 2 public tor_v6ips:

ok: [localhost] => {
    "iptest": {
        "changed": false,
        "msg": "All items completed",
        "results": [
            {
                "_ansible_ignore_errors": null,
                "_ansible_item_label": [
                    "192.168.0.1",
                    "[IPv6_ADDRESS_1]"
                ],
                "_ansible_item_result": true,
                "_ansible_no_log": false,
                "ansible_facts": {
                    "ips": {
                        "ipv4": "192.168.0.1",
                        "ipv6": "[IPv6_ADDRESS_1]"
                    }
                },
                "changed": false,
                "failed": false,
                "item": [
                    "192.168.0.1",
                    "[IPv6_ADDRESS_1]"
                ]
            },
            {
                "_ansible_ignore_errors": null,
                "_ansible_item_label": [
                    "172.16.0.1",
                    "[IPv6_ADDRESS_2]"
                ],
                "_ansible_item_result": true,
                "_ansible_no_log": false,
                "ansible_facts": {
                    "ips": {
                        "ipv4": "172.16.0.1",
                        "ipv6": "[IPv6_ADDRESS_2]"
                    }
                },
                "changed": false,
                "failed": false,
                "item": [
                    "172.16.0.1",
                    "[IPv6_ADDRESS_2]"
                ]
            },
            {
                "_ansible_ignore_errors": null,
                "_ansible_item_label": [
                    "10.24.50.1",
                    null
                ],
                "_ansible_item_result": true,
                "_ansible_no_log": false,
                "ansible_facts": {
                    "ips": {
                        "ipv4": "10.24.50.1",
                        "ipv6": ""
                    }
                },
                "changed": false,
                "failed": false,
                "item": [
                    "10.24.50.1",
                    null
                ]
            }
        ]
    }
}

[nusenu]

thanks for touching this, did you test it?

[goll]

managed to run kitchen tests against debian/ubuntu, centos/fedora fail but I believe for known reasons, unfortunately both freebsd/openbsd fail with the bool error when there is no IPv6, which is probably tied to the upstream issue you opened

will close the PR for now since it's still a WIP

[nusenu]

unfortunately both freebsd/openbsd fail with the `bool` error when there is no IPv6, which is probably tied to the upstream issue you opened

thanks for testing it. Consider adding that info to the upstream issue or open a new one for ipwrap