Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

torrc template: dynamically support new options #192

Closed
nusenu opened this issue Jan 19, 2019 · 2 comments
Closed

torrc template: dynamically support new options #192

nusenu opened this issue Jan 19, 2019 · 2 comments
Assignees
@nusenu
Labels
enhancement

Comments

@nusenu
Copy link
Owner

nusenu commented Jan 19, 2019

Currently we have to manually add new lines to our torrc template everytime a new torrc directive gets added upstream, we should dynamically support new directives, see the pdns role for how this is done:

https://github.com/PowerDNS/pdns-ansible/blob/a0b6057876b6bea698659eff21859b7024a2a4bf/defaults/main.yml#L82

https://github.com/PowerDNS/pdns-ansible/blob/master/templates/pdns.conf.j2#L4

note: we must exclude some options from this (for example those that support per instance config)
@nusenu nusenu self-assigned this Nov 7, 2021
@nusenu
Copy link
Owner Author

nusenu commented Nov 7, 2021

I've an implementation in a local branch that will be pushed soon

nusenu added a commit that referenced this issue Nov 7, 2021
@nusenu
support arbitrary torrc options
302f459 
NOTE: this change is NOT backwards compatible
operator action is required when upgrading to a version that includes
this change

implements #192

previously every torrc option required explicit support in our torrc
template with this change we support arbitrary torrc options
and no changes are required when new torrc options are available

they can be set using the variable `tor_config` which takes a dictionary
with the key being the torrc option and the value the actual setting

example:

```
tor_config:
  SigningKeyLifetime: 90 days
```

some torrc options are not supported in tor_config because we
automatically set them - see the README
@nusenu
Copy link
Owner Author

nusenu commented Nov 16, 2021

implemented in 302f459

since this requires manual steps before upgrading to a version with this change
an upgrade guide has been added to the wiki
https://github.com/nusenu/ansible-relayor/wiki/Upgrade-Guide-from-version-21.1.0-(or-older)-to-a-newer-release

@nusenu nusenu closed this as completed Nov 16, 2021
@nusenu nusenu mentioned this issue Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nusenu nusenu

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nusenu