[Francis Low] Duke Increments #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* branch-A-JavaJX: Add JavaFx GUI Add JavaFx build
# Conflicts: # build.gradle
* branch-A-Checkstyle: Add checkstyle build # Conflicts: # build.gradle
Add assertions
* 'master' of https://github.com/francislow/duke: Improve code quality
ShuTingY
reviewed
Sep 12, 2019
| */ | ||
|
|
||
| public class Storage { | ||
| private static final String filePath = "data/duke.txt"; |
ShuTingY
reviewed
Sep 12, 2019
| * @param i Index of the task to be returned | ||
| * @return Index i of task in list | ||
| */ | ||
| public Task get(int i) { |
There was a problem hiding this comment.
Naming can be improved. What are you trying to get?
ShuTingY
reviewed
Sep 12, 2019
| public String getStartingMessage(TaskList tasks) { | ||
| String message = "Hello! I'm Duke\nWhat can I do for you?\n"; | ||
| if (tasks.size() == 0) { | ||
| message += "You do not have any stored tasks\n"; |
ShuTingY
reviewed
Sep 12, 2019
| import duke.TaskList; | ||
|
|
||
| public abstract class Command { | ||
| protected String[] parts; |
There was a problem hiding this comment.
what this "parts" refer to? can be clearer.
ShuTingY
reviewed
Sep 12, 2019
KartikeKhandelwal
pushed a commit
to KartikeKhandelwal/duke
that referenced
this pull request
Sep 27, 2019
Change file mode on `gradle` to be executable (nus-cs2103-AY1920S1#9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first pull request