[W6.4h][W15-B1]Yang Yuqing #753
Open
+64
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devamanyu
reviewed
Mar 7, 2018
| /** | ||
| * Returns a String representation of an object | ||
| */ | ||
|
|
There was a problem hiding this comment.
Please avoid spaces in between comments and code.
| /** | ||
| * This is an interface to provide an object's printable representation. | ||
| */ | ||
| public interface Printable { |
There was a problem hiding this comment.
Good job in remembering to write comments for the new interface.
| @@ -82,4 +68,12 @@ default String getAsTextHidePrivate() { | |||
| } | |||
| return builder.toString(); | |||
| } | |||
|
|
|||
| default String getPrintableString(Printable... printables) { | |||
| StringJoiner sj = new StringJoiner(" "); | |||
There was a problem hiding this comment.
StringBuilder or StringJoiner can both be used. Good that one of the mentioned is used here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Printable interface [LO-Interfaces]