[W5.11r][T09-B3] Kang Anmin #730
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… These are modifications in running code.
| Changes the phone number of the 2nd person in the address book to 99997777. | ||
| * `find Betsy`<br> | ||
| `changenum 1 88886666`<br> | ||
| Changes the phone number of the 1st person in the results of the `find` command to 88886666. |
There was a problem hiding this comment.
Good job for updating the UserGuide.
|
|
||
|
|
||
| /** | ||
| * Changes the phone number of a person identified using it's last displayed index from the address book. |
There was a problem hiding this comment.
Good job for writing the header comment.
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| public static final String MESSAGE_ALL_USAGES = AddCommand.MESSAGE_USAGE | |||
| + "\n" + DeleteCommand.MESSAGE_USAGE | |||
| + "\n" + ChangeNumCommand.MESSAGE_USAGE | |||
There was a problem hiding this comment.
Good job for updating the help command.
| @@ -66,6 +66,13 @@ public void setTags(UniqueTagList replacement) { | |||
| tags.setTags(replacement); | |||
| } | |||
|
|
|||
| /** | |||
| * Updates the person's phone number to the one in the argument. | |||
There was a problem hiding this comment.
For set and get methods, it's okay to remove the header comment.
| @@ -12,7 +12,7 @@ | |||
| public static final String MESSAGE_PHONE_CONSTRAINTS = "Person phone numbers should only contain numbers"; | |||
| public static final String PHONE_VALIDATION_REGEX = "\\d+"; | |||
|
|
|||
| public final String value; | |||
| public String value; | |||
| * @param str a string | ||
| */ | ||
| private void checkIsPureDigitString (String str) throws IllegalValueException { | ||
| if (!str.matches("[0-9]+")) { |
There was a problem hiding this comment.
Good job for validating the string.
| } | ||
|
|
||
| @Test | ||
| public void execute_changenum_invalid_index() throws Exception { |
There was a problem hiding this comment.
Coding standard violation for the method name..
| } | ||
|
|
||
| @Test | ||
| public void execute_changenum_changesSuccessfully() throws Exception { |
There was a problem hiding this comment.
Good job for testing the new command.
|
@EdwardKSG Some comments added. Please close the PR after reading comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makeup enhancement. Add changenum command to update the phone number of seclected person. UserGuide and tests have been modified accordingly.