-
Notifications
You must be signed in to change notification settings - Fork 78
Make regexes OTP28 compatible #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@nurugger07 anything that we can help to let you merge this PR? |
|
How are we going with merging that? |
|
Anybody has permission to merge? This seems to be an important elixir library but it looks abandoned. Maybe we could move it to a community organization? |
|
Others have just taken the entire library and inlined it into their projects or depend on forks. I have no idea who to contact to merge this and get a new version published. |
|
@josevalim I am sorry to poke you, but this is a very popular library and I was wondering if you had any idea where to fork it to keep it maintained by the community if we cannot get PR merged to this repo. |
|
@warmwaffles thank you for the fix! Until this PR is resolved, my temporary solution is to add the following line to my deps:
Disclaimer: I'm an Elixir beginner. |
|
@timonweb in case you want to have it shorter, you could also do it like this: {:inflex, github: "warmwaffles/inflex", branch: "master", override: true}That's how I have it in my project. |
|
I'll be sure to leave this branch alone until this is merged upstream or until a new package takes over. |
|
thanks for the patch @warmwaffles! |
|
Btw, we will likely have a fix for this in Erlang/OTP 28.1, so stay on 27 until 28.1 is out and you may be able to upgrade without issues. |
|
for the sake of completeness: erlang/otp#9976 |
|
Hmm... This is not fixed with OTP 28.1, is it? |
|
It requires a new Elixir version. |
|
I've pushed a hex build that works on otp28, please send and PRs to noizu-labs-scaffolding/inflex28 def deps do |
This makes the library compatible with OTP28
Closes: #98