False positive for Nunit1029 when only a type argument is use

[cbersch]

The following code

using NUnit.Framework;

namespace NUnitTesting
{
    public sealed class GenericTestMethod
    {
        public static IEnumerable<TestCaseData> Source
            => [new TestCaseData { TypeArgs = [typeof(int)] }];

        [TestCaseSource(nameof(Source))]
        public void Generic<T>()
        {

        }
    }
}

raises an Nunit1029 error "The TestCaseSource provides '>0' parameter(s), but the Test methods expects '0' parameters", which shouldn't be the case.
Tested with NUnit.Analyzers version 4.6.0.

In my opinion, the check in https://github.com/nunit/nunit.analyzers/blob/master/src/nunit.analyzers/TestCaseSourceUsage/TestCaseSourceUsesStringAnalyzer.cs#L260

if (methodRequiredParameters + methodOptionalParameters < 1)

is valid only for non-generic methods and must be changed to

if (methodRequiredParameters + methodOptionalParameters < 1 && !testMethod.IsGenericMethod)

I could provide a PR for this.

[manfred-brands]

For TestCaseData the analyzer doesn't know how many parameters are supplied and it assumes there should at least be one.

You are right that for generic methods the count isn't correct.

You are welcome to create a PR.