Merge pull request #774 from manfred-brands/Issue766_PartialTestClasses

Prevent exception when fields are declared in a different source file.
nunit · Jul 27, 2024 · 48bf08f · 48bf08f
2 parents 5fde5a5 + cb9eb5d
commit 48bf08f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/...DisposeFieldsAndPropertiesInTearDown/DisposeFieldsAndPropertiesInTearDownAnalyzerTests.cs b/...DisposeFieldsAndPropertiesInTearDown/DisposeFieldsAndPropertiesInTearDownAnalyzerTests.cs
@@ -1034,6 +1034,8 @@ public partial class TestFixture
         {{
             private const double Tolerance = 1E-10;
 
+            private IDisposable? field;
+
             private static IDisposable? Property {{ get; set; }}
 
             [SetUp]
@@ -1059,6 +1061,8 @@ public partial class TestFixture
             [Test]
             public void SomeTest()
             {
+                // field needs Disposal, but as TearDown is in a different source 'file' we cannot check if it is.
+                field = new DummyDisposable();
                 SomeAsserts();
             }
         }");

diff --git a/...zers/DisposeFieldsAndPropertiesInTearDown/DisposeFieldsAndPropertiesInTearDownAnalyzer.cs b/...zers/DisposeFieldsAndPropertiesInTearDown/DisposeFieldsAndPropertiesInTearDownAnalyzer.cs
@@ -366,6 +366,12 @@ private static bool NeedsDisposal(SemanticModel model, ExpressionSyntax expressi
         {
             if (IsPossibleDisposableCreation(expression))
             {
+                if (model.SyntaxTree != expression.SyntaxTree)
+                {
+                    // It might need it, but we cannot check it.
+                    return false;
+                }
+
                 ITypeSymbol? instanceType = model.GetTypeInfo(expression).Type;
                 return instanceType is not null &&
                        instanceType.IsDisposable() &&