Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned up package dependencies #23

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Cleaned up package dependencies #23

merged 2 commits into from
Jan 27, 2021

Conversation

Rizary
Copy link
Contributor

@Rizary Rizary commented Jan 27, 2021

No description provided.

@Rizary Rizary requested a review from zimbatm January 27, 2021 10:45
basile-henry
basile-henry approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@basile-henry basile-henry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/lib.rs Outdated Show resolved Hide resolved
@Rizary Rizary merged commit 5206192 into master Jan 27, 2021
@Rizary Rizary deleted the cleanup-deps branch January 27, 2021 13:04
brianmcgee added a commit that referenced this pull request May 13, 2024
@brianmcgee
feat: use go-git index instead of git ls-files (#23)
80e99b6 
Figured out how to use `go-git` properly.

```console
# git

❯ nix run .# -- --config-file ./test/echo.toml --tree-root /home/brian/Development/com/github/nixos/nixpkgs -c
38539 files changed in 272.843495ms

# filesystem

❯ nix run .# -- --config-file ./test/echo.toml --tree-root /home/brian/Development/com/github/nixos/nixpkgs -c --walk filesystem
38567 files changed in 348.84277ms
```

Signed-off-by: Brian McGee <[email protected]>
Reviewed-on: https://git.numtide.com/numtide/treefmt/pulls/23
Reviewed-by: Jonas Chevalier <[email protected]>
Co-authored-by: Brian McGee <[email protected]>
Co-committed-by: Brian McGee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basile-henry basile-henry basile-henry approved these changes

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rizary @basile-henry