Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clap integration #214

Merged
merged 1 commit into from
Jan 20, 2023
Merged

feat: clap integration #214

merged 1 commit into from
Jan 20, 2023

Conversation

aldoborrero
Copy link
Member

Closes #194

@aldoborrero aldoborrero force-pushed the feat/clap branch 2 times, most recently from 59763ef to aba8bef Compare January 20, 2023 14:39
@aldoborrero aldoborrero marked this pull request as ready for review January 20, 2023 15:05
@aldoborrero aldoborrero requested a review from zimbatm January 20, 2023 15:05
@zimbatm zimbatm merged commit 5deccb7 into master Jan 20, 2023
@zimbatm zimbatm deleted the feat/clap branch January 20, 2023 15:35
@zimbatm
Copy link
Member

zimbatm commented Jan 20, 2023

thanks!

1 => LevelFilter::Debug,
_ => LevelFilter::Trace,
})
.filter_level(cli.verbose.log_level_filter())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change we don't get any errors at all. Now the loglevel is dropped to ERROR,
before it was at INFO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from structop to clap
3 participants