Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture stdout/stderr of formatters #7

Closed
zimbatm opened this issue Jan 18, 2021 · 4 comments
Closed

Capture stdout/stderr of formatters #7

zimbatm opened this issue Jan 18, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@zimbatm
Copy link
Member

zimbatm commented Jan 18, 2021

In order to be able to run the formatters in parallel, the formatter run interface should capture the stdout of the command.

Right now, each formatter is executed one by one, and its output displayed on stdout.

In the future, we want to run all formatters concurrently, and display their output in order, once everybody has finished. This is only possible by temporarily capturing their output in memory.

@zimbatm zimbatm changed the title Capture stdout of formatters Capture stdout/stderr of formatters Jan 18, 2021
This was referenced Jan 26, 2021
@zimbatm zimbatm added the enhancement New feature or request label Jan 26, 2021
@Rizary Rizary self-assigned this Feb 5, 2021
@zimbatm zimbatm closed this as completed Feb 27, 2021
@Rizary
Copy link
Contributor

Rizary commented Feb 27, 2021

@zimbatm can you refer to commit id that solved this?

@zimbatm
Copy link
Member Author

zimbatm commented Feb 27, 2021

That was solved by your commit, when you changed to use std::process::Command and output()

@Rizary
Copy link
Contributor

Rizary commented Feb 27, 2021

Oh I thought it gets refactored. Noted.

@zimbatm
Copy link
Member Author

zimbatm commented Feb 27, 2021

It did, but Formatter::fmt also returns an Output

brianmcgee added a commit that referenced this issue May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants