-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not cache files that were part of a batch that had errors when formatting #449
Labels
bug
Something isn't working
Comments
brianmcgee
added a commit
that referenced
this issue
Oct 14, 2024
This was a regression introduced when the new `walk.Reader` approach was applied. When a formatter errors out during processing, we should not update those files in the cache to ensure they are retried during later invocations. I've extended the `walk.ReleaseFunc` to accept an optional `error` which can be used to indicate the file participated in a batch that had errors when being formatted. This allows the hook implementation to decide what it should do. Closes #449 Signed-off-by: Brian McGee <[email protected]>
brianmcgee
added a commit
that referenced
this issue
Oct 14, 2024
This was a regression introduced when the new `walk.Reader` approach was applied. When a formatter errors out during processing, we should not update those files in the cache to ensure they are retried during later invocations. I've extended the `walk.ReleaseFunc` to accept an optional `error` which can be used to indicate the file participated in a batch that had errors when being formatted. This allows the hook implementation to decide what it should do. Closes #449 Signed-off-by: Brian McGee <[email protected]>
brianmcgee
added a commit
that referenced
this issue
Oct 14, 2024
This was a regression introduced when the new `walk.Reader` approach was applied. When a formatter errors out during processing, we should not update those files in the cache to ensure they are retried during later invocations. I've extended the `walk.ReleaseFunc` to accept an optional `error` which can be used to indicate the file participated in a batch that had errors when being formatted. This allows the hook implementation to decide what it should do. Closes #449 Signed-off-by: Brian McGee <[email protected]>
brianmcgee
added a commit
that referenced
this issue
Oct 14, 2024
This was a regression introduced when the new `walk.Reader` approach was applied. When a formatter errors out during processing, we should not update those files in the cache to ensure they are retried during later invocations. I've extended the `walk.ReleaseFunc` to accept an optional `error` which can be used to indicate the file participated in a batch that had errors when being formatted. This allows the hook implementation to decide what it should do. Closes #449 Signed-off-by: Brian McGee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Recent changes on main removed this logic:
The text was updated successfully, but these errors were encountered: