Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding includes and excludes features #13

Closed
Rizary opened this issue Jan 26, 2021 · 1 comment · Fixed by #25
Closed

Adding includes and excludes features #13

Rizary opened this issue Jan 26, 2021 · 1 comment · Fixed by #25
Assignees
@Rizary
Labels
enhancement New feature or request

Comments

@Rizary
Copy link
Contributor

Rizary commented Jan 26, 2021

According to the initial design, prjfmt.toml has includes and excludes features:

[formatters.cargo]
files = [ "*.rs" ]
includes = [ "rust/" ]
excludes = []
command = "cargo"
args = [ "fmt", "--" ]

The behavior on includes is that all files selected should only be in the includes location. excludes is the opposite, which means all files selected should avoid the excludes location.

includes and excludes cannot contain the same values.
@Rizary Rizary self-assigned this Jan 26, 2021
@zimbatm
Copy link
Member

zimbatm commented Jan 26, 2021

Make sure to update the README.md in the PR so it's in sync

@zimbatm zimbatm added the enhancement New feature or request label Jan 26, 2021
@Rizary Rizary mentioned this issue Jan 27, 2021
Closed
basile-henry added a commit that referenced this issue Jan 28, 2021
@basile-henry
Use ignore for better control over globbing
58074d9 
resolves #13: Includes and excludes
resolves #24: Follows .gitgnore directives
@basile-henry basile-henry mentioned this issue Jan 28, 2021
Merged
brianmcgee added a commit that referenced this issue May 13, 2024
@zimbatm @brianmcgee
feat: support global excludes (#13)
96b1560 
Stacked on top of #11

Co-authored-by: Brian McGee <[email protected]>
Reviewed-on: https://git.numtide.com/numtide/treefmt/pulls/13
Co-authored-by: zimbatm <[email protected]>
Co-committed-by: zimbatm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rizary Rizary

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ignore for better control over globbing numtide/treefmt
2 participants
@zimbatm @Rizary