bb-app: init at 0.36.0 - #7750
Merged
Merged
Conversation
Mic92
reviewed
Aug 11, 2026
| binaryBytecode | ||
| binaryNativeCode | ||
| ]; | ||
| maintainers = with maintainers; [ ]; |
Member
There was a problem hiding this comment.
CI error.
New packages: bb-app
Error: New package 'bb-app' has empty meta.maintainers. Add yourself (see lib/default.nix for the local maintainer list).
Error: Process completed with exit code 1.
The "Check maintainers on new packages" CI job requires every new package to declare at least one meta.maintainers entry. bb-app shipped with an empty list, so the check failed. Register jvmncs in the local maintainer list and reference it from the package. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016gvyqKkEPBeMgSd3khpnf9
Replace the bespoke update.py with the shared update_npm_package flow; it already covers version bump, lockfile regeneration with strip_dev_dependencies, and npmDepsHash recalculation. Move the npm 11 integrity workaround into extract_or_generate_lockfile: npm 11 omits resolved/integrity for deduplicated lockfile entries, which breaks npm ci and Nix's npm prefetcher for every generated lockfile, not just bb-app's. Skip bundled and linked entries, which legitimately carry no integrity. In package.nix, drop the package.json version assertion (the version comes from the fetched tarball, so it is true by construction) and the meta = with lib; scope in favor of explicit lib references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing