Skip to content

Add inputDerivation to enable binary caching#226

Closed
amarshall wants to merge 1 commit intonumtide:mainfrom
amarshall:inputDerivation
Closed

Add inputDerivation to enable binary caching#226
amarshall wants to merge 1 commit intonumtide:mainfrom
amarshall:inputDerivation

Conversation

@amarshall
Copy link
Contributor

Same rationale as upstream, see
NixOS/nixpkgs#95536

@amarshall amarshall changed the title Add inputDerivation Add inputDerivation to enable binary caching Oct 19, 2022
@brianmcgee
Copy link
Member

@amarshall is this ready for review if it was updated with latest main?

Same rationale as upstream, see
NixOS/nixpkgs#95536
@amarshall
Copy link
Contributor Author

@brianmcgee should be, yes, I have rebased off latest and force-pushed. There were no conflicts.

@zimbatm
Copy link
Member

zimbatm commented Mar 2, 2023

Sorry, I should have reacted earlier; this change is not needed. Unlike upstream's mkShell, mkNakedShell was designed to be built or loaded as a nix-shell. This was part of the design, so you can nix-build the devshell, which has references to all the inputs. So instead of nix-build shell.nix -A inputDerivation | cachix push, you can already nix-build shell.nix | cachix push.

@amarshall
Copy link
Contributor Author

@zimbatm Hmm, I remember I did this because some things weren’t getting uploaded to the cache as expected, but we’ve since changed to using a post-build hook instead anyway. I’ll try to reproduce.

@zimbatm
Copy link
Member

zimbatm commented Mar 6, 2023

Ok, let me know if you can build a repro

@zimbatm
Copy link
Member

zimbatm commented Jun 28, 2023

I'm going to assume that it was fine :)

@zimbatm zimbatm closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants