MAINT: Remove scale to work around PyPI bug #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jarrodmillman feel free to merge if you're happy -- I also added the CIs runs as requirements for merge so that in the future we can do merge-when-green if wanted (and to provide a bit of extra protection) |
jarrodmillman
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around pypa/readme_renderer#304 by removing
:scale:which doesn't seem necessary anyway. Also makes thetwine check --strictpart of all PR runs to catch this sort of thing sooner and make sure we don't break our packaging somehow.Closes #577
Locally in an isolated env I get that it passes the
twine check