Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update dependency installation order #86

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

rossbar
Copy link
Collaborator

@rossbar rossbar commented Jun 17, 2021

A quick fix to prevent the pip dependency resolver from borking when trying to install jupytext and myst-nb sequentially.

A bit of background:

The motivation for keeping two separate requirements files is that the requirements that are needed to build the website (site/requirements.txt) are not required in order to simply run the tutorials as jupyter notebooks locally (as one would do either on their own machine or binder). However, the dependency management between myst-nb and jupytext has caused problems in the past: see executablebooks/MyST-NB#289 and executablebooks/MyST-NB#333). This reordering avoids the problem reported in the latter.

@melissawm melissawm merged commit 173e93f into numpy:main Jun 17, 2021
@melissawm
Copy link
Member

Thanks for keeping an eye on this, @rossbar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants