feat(features/home): update profile name #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Display and update profile name instead of username. - Reduce duplicate API calls for profile. - Remove unused pages: ProfilePage and PhoneVerificationPage, and the service DiaBackendAssetRefreshingService.
shc261392
reviewed
Oct 29, 2024
| map(profile => profile.profile_background_thumbnail) | ||
| ); | ||
| readonly form = new UntypedFormGroup({}); | ||
| model: EditProfileFormModel = { | ||
| username: '', | ||
| displayName: '', |
There was a problem hiding this comment.
Found it in some cases it referred to as profileName (e.g. transaltion) and sometimes displayName. Maybe use profileName for all Ionic side variables and use display_name only on backend API response?
src/app/features/profile/phone-verification/phone-verification.page.html
Outdated
Show resolved
Hide resolved
shc261392
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Removed
ProfilePageandPhoneVerificationPage, and the serviceDiaBackendAssetRefreshingService#3255
┆The issue is also created on Asana