Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v230725 issue some device can’t record 15s short by capture camera #2966

Conversation

sultanmyrza
Copy link
Contributor

@sultanmyrza sultanmyrza commented Aug 3, 2023

This PR implements Comment by @Sam on [issue] Some device can’t record 15s SHORT by Capture camera. (Not using video uploading.).

Displays a dialog when users select a video or image from the gallery, and its size exceeds 30MB. The informative message "File size exceeds 30MB..." will appear in such cases.However, when capturing media using the capture cam, the dialog won't be shown, regardless of the media's size, even if it exceeds 30MB.

┆Issue is synchronized with this Asana task by Unito

This commit displays a dialog when users select a video or image from the gallery, and its size exceeds 30MB. The informative message "File size exceeds 30MB..." will appear in such cases.

However, when capturing media using the capture cam, the dialog won't be shown, regardless of the media's size, even if it exceeds 30MB.

This enhancement keeps users informed about the file size limit, aiding them in making better decisions while selecting media from the gallery.
Rename showIsFileSizeExceeded to showFileSizeExceeded cause
it makes more sense.
…-issue-Some-device-can’t-record-15s-SHORT-by-Capture-camera'
@sultanmyrza sultanmyrza merged commit 64ee163 into milestone-v230725 Aug 3, 2023
sultanmyrza added a commit that referenced this pull request Aug 7, 2023
…ue-Some-device-can’t-record-15s-SHORT-by-Capture-camera"

This reverts commit 64ee163, reversing
changes made to 4630fb9.
@sultanmyrza sultanmyrza deleted the fix-v230725-issue-Some-device-can’t-record-15s-SHORT-by-Capture-camera branch January 21, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant