Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature in app puchase #1718

Merged
merged 19 commits into from
Jun 21, 2022
Merged

Feature in app puchase #1718

merged 19 commits into from
Jun 21, 2022

Conversation

sultanmyrza
Copy link
Contributor

@sultanmyrza sultanmyrza commented Jun 20, 2022

┆Issue is synchronized with this Asana task by Unito

) {}

ngOnInit() {
this.store.refreshNumPointsPricing();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncaught exception in test here:
https://github.com/numbersprotocol/capture-lite/runs/6976944629?check_suite_focus=true

It doesn't seem to affect functionality. Maybe just catch this error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shc261392 sure will wrap to try-catch block. By the way, do we need to add BUBBLE_API_URL to the GitHub builds env vars?

<ion-content *transloco="let t">
<ion-list lines="none">
<ion-list-header *ngIf="(totalProducts$ | async) === 0">
In App Products are not available yet. Try again later
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok for this message to be English-only without translation?

Comment on lines 295 to 297
"pointsAdded": "加了{{points}}分",
"failedToAddPoints": "加分失敗",
"thisPackageIncludesXNumPoints": "此套餐包括{{points}}個 NUM 分。",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is not very intuitive for Chinese speaker users. Maybe consult with Sofia for translations?

@@ -348,5 +356,9 @@
"pleaseUpdateTheAppForProperFunctioning": "請更新應用程序以使其正常運行",
"remindMeTomorrow": "明天提醒我",
"updateNow": "現在更新"
},
"inAppPurchase": {
"failedToInitInAppStore": "In-App Store 初始化期間發生錯誤。 請檢查您的互聯網連接質量。",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording is in Simplified-Chinese style and may get dislikes for Traditional Chinese users. Might need to consult with Sofia to adjust the translation.

Copy link
Contributor

@shc261392 shc261392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants